Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Image Algorithm to Bilinear #4159

Merged
merged 7 commits into from
Dec 27, 2021

Conversation

willhuang1997
Copy link
Collaborator

@willhuang1997 willhuang1997 commented Dec 11, 2021

Did some testing and Lanczos is the best algorithm to resize but it's a bit slower but NOT that much slower (maybe 10% slower than Bicubic but a little bit better quality). Especially since I don't think Streamlit users will be using st.image that many times for the performance to take a hit.

For now, the Streamlit team has agreed to use bilinear since that's what other browsers are using and the difference in quality is not very noticeable.

Notion doc down below.
Screen Shot 2021-12-10 at 3 56 28 PM

Adding notion doc: https://www.notion.so/streamlit/f820815df991408789cfbed1b2b4d3f3?v=3a50f3730b1543b3bc0682d6f193a863

Note: The experimentation is only done on localhost. I haven't tried it on cloud.

@willhuang1997 willhuang1997 changed the title Changing Image Algorithm to Lanczos Changing Image Algorithm to Bilinear (Changed my mind on Lanczos) Dec 21, 2021
@willhuang1997 willhuang1997 merged commit 9751d25 into streamlit:develop Dec 27, 2021
@willhuang1997 willhuang1997 deleted the image_resize_algorithm branch December 27, 2021 23:39
tconkling added a commit to tconkling/streamlit that referenced this pull request Jan 3, 2022
* develop:
  Fix hello demo type annotation (streamlit#4228)
  Release 1.3.1 (streamlit#4220)
  Improve beta_ deprecation message (streamlit#4219)
  Changing Image Algorithm to Bilinear (streamlit#4159)
  Allow columns to be rendered to create spacing (streamlit#4217)
  Fix issue with hidden balloons (approach 2) (streamlit#4204)
  Fix mypy errors from 0.930 release (streamlit#4218)
  Fix/selectbox typings (streamlit#4194)
  Support running tests locally on Apple Silicon (streamlit#4185)
  Stop screencast recorder when user removes permission / stops using browser button. (streamlit#4180)
@kmcgrady kmcgrady changed the title Changing Image Algorithm to Bilinear (Changed my mind on Lanczos) Changing Image Algorithm to Bilinear Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants