[Pure design change] Make checkbox/radio only show focus when tabbing, not when clicked. #4308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Focus queues are often confusing for mouse-based users (why is there sometimes a box around this element?). To help with this, in this PR I replace the "focus" state with the "focus-visible" state, which tries to be smart about when to draw focus queues around an element. Here's a nice little write-up about "focus-visible": https://matthiasott.com/notes/focus-visible-is-here
tvst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
Focus queues are often confusing for mouse-based users (why is there
sometimes a box around this element?). To help with this, in this PR I
replace the "focus" state with the "focus-visible" state, which tries to
be smart about when to draw focus queues around an element.
Here's a nice little write-up about "focus-visible":
https://matthiasott.com/notes/focus-visible-is-here
🧠 Description of Changes
Make checkbox and radio focus use "focus-visible" rather than "focus"
Revised:
Insert screenshot of your updated UI/code here
Current:
Insert screenshot of existing UI/code here
🧪 Testing Done
No existing tests are impacted by this change, and I felt the cost/benefit ratio of writing of new tests just for this would be too high (high cost, low benefit). LMK if you think otherwise!
🌐 References
Does this depend on other work, documents, or tickets?
No. This is a very minor change, not connected to any existing issue.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.