Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line example app #467

Closed
wants to merge 1 commit into from
Closed

Conversation

markopy
Copy link

@markopy markopy commented Oct 19, 2019

This example app shows how to handle command line arguments and presumably resolves issue #337.

Contribution License Agreement

By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@tvst
Copy link
Contributor

tvst commented Oct 22, 2019

Hi @markopy!

We really appreciate the contribution, but we're actually in the process of removing examples/*.py from this repo. These examples weren't meant for end-user consumption but rather for dev testing. Since then we've added proper e2e tests to Streamlit, which means now examples/*.py are no longer needed.

That said, we're soon going to write a set of much more useful examples and put them on a separate "streamlit-cookbook" repo. This seems like a possible entry for that.

So I'm afraid I'll have to close this PR for now and keep it in mind for inclusion in the new repo later. Sorry!

To avoid this next time, please check in before working on a contribution, as described in our Contributing page.

@tvst tvst closed this Oct 22, 2019
@markopy
Copy link
Author

markopy commented Oct 22, 2019

No problem @tvst . I admittedly didn't look closely at what's in the examples folder and just assumed it is where this should go. For now I have created a gist instead: https://gist.github.com/markopy/ff82a054de47612f748fb6e388bf5588

monchier added a commit that referenced this pull request Nov 15, 2019
…) (#603)

* Do not create credential file in headless mode

* linter

* wip

* linter

* tests

* linter

* refactoring. Added test.

* renamee

* fixing bug where we were testing config.toml instead of credential.toml

* linter

* reverting not needed changes

* removing comment

* Making patching more explicit

* linter

* some review comments

* fix test
tconkling added a commit to tconkling/streamlit that referenced this pull request Nov 19, 2019
* develop: (31 commits)
  fixed misspell (streamlit#712)
  Add ConfigOption attribute "scriptable" w/ only some options scriptable=True (streamlit#702)
  Fixing Tornado on Windows + Python 3.8 (streamlit#682)
  Moving reportId and metadata from Element to ReportElement (streamlit#529)
  Fall back on webbrowser if xdg-open is not installed on Linux (streamlit#701)
  Dockerfile: ensure we install the NODE_VERSION we reference elsewhere (streamlit#639)
  Datepicker pop-up aligned on left (streamlit#676)
  Fixing number input spin buttons for Firefox (streamlit#683)
  Fixing makeElementWithInfoText (streamlit#692)
  Fixing CTRL+ENTER on Windows (streamlit#699)
  Add option to use PollingFileWatcher, even if watchdog is available (streamlit#626)
  Break util.py into several util files (streamlit#703)
  Do not automatically create credential file when in headless mode (streamlit#467) (streamlit#603)
  make __future__ import be the first line (streamlit#687)
  Split text protos (streamlit#506)
  pandas.isna was introduced in version 0.21.0 (streamlit#679)
  Prefix get_report_ctx with underscore in __init__ and import it correctly in (streamlit#669)
  Fix single word in changelog (streamlit#672)
  Move some functions from util.py into type_util.py (streamlit#670)
  Release 0.50.2 (streamlit#666)
  ...
tconkling added a commit to tconkling/streamlit that referenced this pull request Nov 19, 2019
* develop: (38 commits)
  Add viz.js to the repo (streamlit#635)
  fixed misspell (streamlit#712)
  Add ConfigOption attribute "scriptable" w/ only some options scriptable=True (streamlit#702)
  Fixing Tornado on Windows + Python 3.8 (streamlit#682)
  Moving reportId and metadata from Element to ReportElement (streamlit#529)
  Fall back on webbrowser if xdg-open is not installed on Linux (streamlit#701)
  Dockerfile: ensure we install the NODE_VERSION we reference elsewhere (streamlit#639)
  Datepicker pop-up aligned on left (streamlit#676)
  Fixing number input spin buttons for Firefox (streamlit#683)
  Fixing makeElementWithInfoText (streamlit#692)
  Fixing CTRL+ENTER on Windows (streamlit#699)
  Add option to use PollingFileWatcher, even if watchdog is available (streamlit#626)
  Break util.py into several util files (streamlit#703)
  Do not automatically create credential file when in headless mode (streamlit#467) (streamlit#603)
  make __future__ import be the first line (streamlit#687)
  Split text protos (streamlit#506)
  pandas.isna was introduced in version 0.21.0 (streamlit#679)
  Prefix get_report_ctx with underscore in __init__ and import it correctly in (streamlit#669)
  Fix single word in changelog (streamlit#672)
  Move some functions from util.py into type_util.py (streamlit#670)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants