Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations for media #4706

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

harahu
Copy link
Contributor

@harahu harahu commented May 8, 2022

馃摎 Context

Continuing from where I left off in #4657

  • What kind of change does this PR introduce?

    • Other, please describe: Type Annotations

馃 Description of Changes

  • Add type annotations for the media module

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@vdonato vdonato merged commit ca32c34 into streamlit:develop May 10, 2022
tconkling added a commit that referenced this pull request May 10, 2022
* develop: (21 commits)
  Remove branching imports and always import from typing_extensions (#4699)
  Add type annotations for media (#4706)
  Components adjustments (#4694)
  Type annotations for type_util (#4704)
  Add type annotations for utils (#4703)
  Argument types for iframe (#4707)
  Add type annotations for write (#4686)
  Add type annotations for doc_string (#4690)
  Add type annotations for progress (#4688)
  Add type annotations for exception (#4681)
  Add type annotations for plotly_chart (#4684)
  Wrap Markdown text when there's no word break (#4696)
  Add type annotations for __init__.py (#4687)
  Make typing-extensions and unconditional dependency (#4697)
  Add type annotations for balloons (#4679)
  Add type annotations for empty (#4680)
  Add type annotations for json (#4682)
  Add type annotations for layouts (#4683)
  Add type annotations for snow (#4685)
  Import Final from typing or typing_extensions depending on the Python version (#4692)
  ...
@harahu harahu deleted the harahu/types/media branch May 21, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants