New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations for time widgets #4710
Add type annotations for time widgets #4710
Conversation
@vdonato @LukasMasuch This one will fail type checking if #4733 goes through, and vice versa, since it determines whether the final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small renaming suggestion, but otherwise LGTM 馃憤
bda0fb8
to
5811b34
Compare
@LukasMasuch It seems I was wrong about this assumption. These elements are widgets, and hence, do not use |
馃摎 Context
Continuing from where I left off in #4657
What kind of change does this PR introduce?
馃 Description of Changes
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.