Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number input returns consistent type after rerun #5359

Merged
merged 2 commits into from
Sep 17, 2022

Conversation

sfc-gh-kbregula
Copy link
Contributor

馃摎 Context

Hi.
I noticed that number_input does not affect the type response when deserializing.
Close: #4319

Best regards,
Kamil Bregu艂a

Please describe the project or issue background here

  • What kind of change does this PR introduce?

    • Bugfix
    • Feature
    • Refactoring
    • Other, please describe:

馃 Description of Changes

  • Add bullet points summarizing your changes here

    • This is a breaking API change
    • This is a visible (user-facing) change

Revised:

Insert screenshot of your updated UI/code here

Current:

Insert screenshot of existing UI/code here

馃И Testing Done

  • Screenshots included
  • Added/Updated unit tests
  • Added/Updated e2e tests

馃寪 References

Does this depend on other work, documents, or tickets?

  • Issue: Closes #XXXX

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-kbregula sfc-gh-kbregula added the type:bug Something isn't working label Sep 15, 2022
@sfc-gh-kbregula sfc-gh-kbregula requested a review from a team September 15, 2022 22:46
Copy link
Contributor

@tconkling tconkling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sfc-gh-kbregula - this looks good, but needs (at least one) test please :) (Specifically, a test that would fail with the previous behavior, and passes with the patch.)

@sfc-gh-kbregula
Copy link
Contributor Author

@tconkling That's right. At first I had a problem with how to do it and wanted to do a PR without testing, but then I forgot to do a git push. Now the PR has a test and a fix.

Copy link
Contributor

@tconkling tconkling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@sfc-gh-kbregula sfc-gh-kbregula merged commit 7568f1c into develop Sep 17, 2022
@sfc-gh-kbregula sfc-gh-kbregula deleted the sfc-gh-kbregula-4319-number-input branch September 19, 2022 09:09
tconkling added a commit that referenced this pull request Sep 19, 2022
* develop:
  Fix python-max-version check failure (#5367)
  Number input returns consistent type after rerun (#5359)
  Remove outline in help messages (#5275)
  Require more strict reviews on protobuf changes (#5354)
tconkling added a commit to tconkling/streamlit that referenced this pull request Sep 20, 2022
* feature/MediaFileManager:
  Fix python-max-version check failure (streamlit#5367)
  Number input returns consistent type after rerun (streamlit#5359)
  Remove outline in help messages (streamlit#5275)
  Require more strict reviews on protobuf changes (streamlit#5354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent type returned by number_input
2 participants