Fix on menu highlights #6034
Merged
Fix on menu highlights #6034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-tszerszen
approved these changes
Feb 2, 2023
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This PR fixes an issue reported by @tvst, where it’s easy to get to a state where there’s a menu item highlighted in both the viewer menu and the dev menu at the same time. We believe this issue could've been introduced recently, after we upgraded BaseWeb.
What kind of change does this PR introduce?
🧠 Description of Changes
Updated
backgroundColorstyles to apply on:hoverfor the<StyledMenuItem>and<StyledDevItem>components;Revised:
Kapture.2023-01-30.at.17.29.49.mp4
Current:
Screen.Recording.2023-01-25.at.13.57.04.mov
🧪 Testing Done
🌐 References
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.