Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CTRL+ENTER on Windows #699

Merged
merged 1 commit into from Nov 18, 2019

Conversation

arraydude
Copy link
Contributor

Issue: This PR fixes #696
Description: Enter key has different keyCode depending on browser and OS


Contribution License Agreement

By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@arraydude arraydude requested a review from a team as a code owner November 15, 2019 17:23
@arraydude arraydude merged commit 6a0a29e into streamlit:develop Nov 18, 2019
@arraydude arraydude deleted the 696/CtrlEnterOnWindows branch November 18, 2019 21:29
tconkling added a commit to tconkling/streamlit that referenced this pull request Nov 19, 2019
* develop: (31 commits)
  fixed misspell (streamlit#712)
  Add ConfigOption attribute "scriptable" w/ only some options scriptable=True (streamlit#702)
  Fixing Tornado on Windows + Python 3.8 (streamlit#682)
  Moving reportId and metadata from Element to ReportElement (streamlit#529)
  Fall back on webbrowser if xdg-open is not installed on Linux (streamlit#701)
  Dockerfile: ensure we install the NODE_VERSION we reference elsewhere (streamlit#639)
  Datepicker pop-up aligned on left (streamlit#676)
  Fixing number input spin buttons for Firefox (streamlit#683)
  Fixing makeElementWithInfoText (streamlit#692)
  Fixing CTRL+ENTER on Windows (streamlit#699)
  Add option to use PollingFileWatcher, even if watchdog is available (streamlit#626)
  Break util.py into several util files (streamlit#703)
  Do not automatically create credential file when in headless mode (streamlit#467) (streamlit#603)
  make __future__ import be the first line (streamlit#687)
  Split text protos (streamlit#506)
  pandas.isna was introduced in version 0.21.0 (streamlit#679)
  Prefix get_report_ctx with underscore in __init__ and import it correctly in (streamlit#669)
  Fix single word in changelog (streamlit#672)
  Move some functions from util.py into type_util.py (streamlit#670)
  Release 0.50.2 (streamlit#666)
  ...
tconkling added a commit to tconkling/streamlit that referenced this pull request Nov 19, 2019
* develop: (38 commits)
  Add viz.js to the repo (streamlit#635)
  fixed misspell (streamlit#712)
  Add ConfigOption attribute "scriptable" w/ only some options scriptable=True (streamlit#702)
  Fixing Tornado on Windows + Python 3.8 (streamlit#682)
  Moving reportId and metadata from Element to ReportElement (streamlit#529)
  Fall back on webbrowser if xdg-open is not installed on Linux (streamlit#701)
  Dockerfile: ensure we install the NODE_VERSION we reference elsewhere (streamlit#639)
  Datepicker pop-up aligned on left (streamlit#676)
  Fixing number input spin buttons for Firefox (streamlit#683)
  Fixing makeElementWithInfoText (streamlit#692)
  Fixing CTRL+ENTER on Windows (streamlit#699)
  Add option to use PollingFileWatcher, even if watchdog is available (streamlit#626)
  Break util.py into several util files (streamlit#703)
  Do not automatically create credential file when in headless mode (streamlit#467) (streamlit#603)
  make __future__ import be the first line (streamlit#687)
  Split text protos (streamlit#506)
  pandas.isna was introduced in version 0.21.0 (streamlit#679)
  Prefix get_report_ctx with underscore in __init__ and import it correctly in (streamlit#669)
  Fix single word in changelog (streamlit#672)
  Move some functions from util.py into type_util.py (streamlit#670)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text_area Ctrl-Enter action does not update
2 participants