Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Pulsar batch handling #638

Merged
merged 6 commits into from May 23, 2022
Merged

Support Pulsar batch handling #638

merged 6 commits into from May 23, 2022

Conversation

mattisonchao
Copy link
Member

Motivation

see #28

In the current implementation, the batch message will split to MQTT message to the client, but not handle the individual ack.

Modifications

  • When this message is part of a batch, use the bitset to individual acknowledge the message.
  • Make setAcknowledgmentAtBatchIndexLevelEnabled is always true.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • no-need-doc

@mattisonchao mattisonchao modified the milestones: 2.10.1, 2.11.0 May 19, 2022
@mattisonchao mattisonchao marked this pull request as ready for review May 19, 2022 14:24
@mattisonchao mattisonchao requested review from codelipenghui and a team as code owners May 19, 2022 14:24
@Technoboy- Technoboy- merged commit 0d0af93 into streamnative:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@mattisonchao mattisonchao

Labels
None yet
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattisonchao @Technoboy-