Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

escape forward slashes in streamId when calling publishHttp #184

Merged
merged 2 commits into from
Feb 18, 2021
Merged

escape forward slashes in streamId when calling publishHttp #184

merged 2 commits into from
Feb 18, 2021

Conversation

@harbu
Copy link
Contributor

@harbu harbu commented Dec 16, 2020

Escape forward slahes in streamId url parameter when using publishHttp to publish messages

@harbu harbu requested a review from teogeb December 16, 2020 17:02
@teogeb
Copy link
Contributor

teogeb commented Dec 18, 2020 •
edited
Loading

If you use getEndpointUrl(this.options.restUrl, 'streams', streamId, 'data'), the method encodes the path segments automatically. We could also fix createStream to use getEndpointUrl(this.options.restUrl, 'streams') for consistency.

@timoxley timoxley force-pushed the add-encodeURIComponent-to-publish-http branch from 7c34c96 to c0b8d3e Compare February 10, 2021 15:41
@timoxley timoxley force-pushed the add-encodeURIComponent-to-publish-http branch from c0b8d3e to a675f20 Compare February 10, 2021 18:34
@timoxley timoxley merged commit 3133990 into master Feb 18, 2021
@timoxley timoxley deleted the add-encodeURIComponent-to-publish-http branch February 18, 2021 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@teogeb teogeb Awaiting requested review from teogeb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harbu @teogeb @timoxley