This repository was archived by the owner on Dec 21, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Persist GroupKeys #204
Merged
Merged
Persist GroupKeys #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NET-156 Persist encryption keys in JS client
The JS client currently includes an in-memory store for encryption keys. We should add an option for persistent storage, so that keys aren't lost across process restarts / page reloads. A simple persistent key-value store is basically be enough. Sure, it's not very secure to store the keys in plaintext, but it's good enough as a first step at least. But how to persist keys in a way that works in both node.js as well as browser, ideally without platform-specific code in the client library? Is there a drop-in replacement for |
286eb4a to
1990831
Compare
1990831 to
692d091
Compare
4a26fda to
ed74cd6
Compare
485ad88 to
596c415
Compare
b40f690 to
9987646
Compare
14bd1ee to
f3193a6
Compare
…nding promise de-duplication.
5681655 to
3b58f50
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores keys in system config directory on server or localstorage in browser (stubbed in, yet to be tested).
Needs
Maybe