This repository was archived by the owner on Dec 21, 2021. It is now read-only.
NET-286: Storage node constants #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yStorageNode accept StorageNode instance as a parameter
NET-286 Expose the address of Streamr Germany storage node as a constant
Note that there can be many storage nodes in the future. Also expose the streamr-docker-dev storage node with some name. |
timoxley
approved these changes
May 10, 2021
Contributor
timoxley
left a comment
timoxley
left a comment
There was a problem hiding this comment.
Yep this is much better. Worth updating readme? Otherwise lgtm.
bearni95
pushed a commit
that referenced
this pull request
May 17, 2021
Added constants StorageNode.STREAMR_GERMANY and StorageNode.STREAMR_DOCKER_DEV. The values are instances of StorageNode class. The parameter of addToStorageNode, removeFromStorageNode and getStreamPartsByStorageNode can now be a StorageNode instance or a string.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added constants
StorageNode.STREAMR_GERMANYandStorageNode.STREAMR_DOCKER_DEV. The values are instances ofStorageNodeclass.The parameter of
addToStorageNode,removeFromStorageNodeandgetStreamPartsByStorageNodecan now be aStorageNodeinstance or astring.