[P1] Command Payload Not Marshaled to JSON Before Database Insert

[JoshuaAFerguson]

Severity: P1 - HIGH
Component: API - Agent Command Creation
Report: BUG_REPORT_P1_COMMAND_PAYLOAD_JSON_MARSHALING.md

Issue

Command payload passed as Go map directly to database instead of marshaling to JSON first.

Impact

• Session termination broken
• Command payloads not stored correctly
• Agent receives invalid/corrupted payload
• Type assertion failures

Root Cause

CreateCommand function passes payload as map[string]interface{} directly to database query:

// WRONG - Go map not JSON
payload := map[string]interface{}{
    "sessionID": sessionID,
    "reason": "user_requested",
}

_, err := db.Exec(`
    INSERT INTO agent_commands (payload, ...)
    VALUES ($1, ...)
`, payload, ...)  // ERROR: Cannot insert Go map

Fix Required

Marshal payload to JSON before insert:

payload := map[string]interface{}{
    "sessionID": sessionID,
    "reason": "user_requested",
}

// Marshal to JSON
payloadJSON, err := json.Marshal(payload)
if err != nil {
    return fmt.Errorf("failed to marshal payload: %w", err)
}

_, err = db.Exec(`
    INSERT INTO agent_commands (payload, ...)
    VALUES ($1, ...)
`, payloadJSON, ...)  // Correct: JSON bytes

Alternative Fix

Use json.RawMessage:

var payloadJSON json.RawMessage
payloadJSON, err := json.Marshal(payload)

Files to Fix

• Find all CreateCommand calls
• api/internal/handlers/sessions.go (DeleteSession)
• api/internal/websocket/hub.go (if creating commands)
• Any other command creation code

Testing

• Commands inserted successfully
• Payload stored as valid JSON in DB
• Agent receives correct payload
• Session termination works end-to-end

Effort: 1-2 hours
Source: .claude/reports/BUG_REPORT_P1_COMMAND_PAYLOAD_JSON_MARSHALING.md

[JoshuaAFerguson]

Status: Not Yet Implemented

Priority: P1 (High Priority)

Issue Summary: Command payload not properly marshaled to JSON before database insertion, causing query errors.

Identified Problems:

1. Payload likely being inserted as Go struct instead of JSON string
2. Database expects JSONB type but receives invalid format

Current Status: This backend bug has not been addressed yet. Focus has been on P0 UI crashes and critical WebSocket bugs.

Next Steps:

1. Review command creation handlers in api/internal/handlers/
2. Add json.Marshal() call for payload before database insert
3. Verify JSONB column type in database schema
4. Add test coverage for command creation with various payload types

Timeline: Should be addressed in next backend bug fix cycle

Branch: claude/v2-builder (no changes for this issue yet)

[JoshuaAFerguson]

Closing as fixed. The handlers do payloadJSON, err := json.Marshal(payload) before inserting into the agent_commands table — see api/internal/api/handlers.go:804, 1025, 1160, 1295. The JSON marshaling step is in place.