Skip to content

fix(ci): bump GO_VERSION to 1.25 + golangci-lint v2.5 + repair sha tag #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaAFerguson merged 1 commit into from
Apr 25, 2026
Merged

fix(ci): bump GO_VERSION to 1.25 + golangci-lint v2.5 + repair sha tag #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ jobs:
run: |
go fmt ./...
go vet ./...
# Install golangci-lint
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.55.2
# Install golangci-lint (pinned to a version that supports the modules' Go directive)
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b "$(go env GOPATH)/bin" "${GOLANGCI_LINT_VERSION}"

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Define golangci-lint version before expanding it

"${GOLANGCI_LINT_VERSION}" is used here, but this workflow never defines that variable (the top-level env only sets GO_VERSION and NODE_VERSION). In bash, this expands to an empty argument, so the installer falls back to an implicit/latest release instead of the pinned version described in the change, making CI behavior non-reproducible and vulnerable to future lint breakage when upstream releases change.

Useful? React with 👍 / 👎.

golangci-lint run

- name: Download API dependencies
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/container-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}}
type=sha,prefix={{branch}}-
type=sha,prefix=sha-
type=raw,value=latest,enable={{is_default_branch}}

- name: Set build variables
Expand Down Expand Up @@ -234,7 +234,7 @@ jobs:
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}}
type=sha,prefix={{branch}}-
type=sha,prefix=sha-
type=raw,value=latest,enable={{is_default_branch}}

- name: Set build variables
Expand Down Expand Up @@ -403,7 +403,7 @@ jobs:
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern={{major}}
type=sha,prefix={{branch}}-
type=sha,prefix=sha-
type=raw,value=latest,enable={{is_default_branch}}

- name: Set build variables
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/security-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: '1.24'
go-version: '1.25'

- name: Download dependencies
run: |
Expand Down
Loading