chore(security): bump docker SDK v25 → v28.5.2 + rename moved types#257
Merged
Conversation
Resolves the 3 remaining open Dependabot alerts on github.com/docker/docker (GHSA-x744-4wpc-v9h2 high, GHSA-pxq6-2prw-chj9 medium, plus the forward-looking GHSA-vvgc-356p-c3xw range — v29 isn't published yet, v28.5.2 is the current latest tagged release). The v25 → v28 jump moved several API types out of the umbrella api/types package into per-domain subpackages: types.NetworkListOptions -> network.ListOptions types.NetworkCreate -> network.CreateOptions types.ImagePullOptions -> image.PullOptions types.ContainerStartOptions -> container.StartOptions types.ContainerRemoveOptions-> container.RemoveOptions types.ContainerListOptions -> container.ListOptions Renamed in agent_docker_operations.go. Imported the image package under the `dockerimage` alias because there's a local `image string` parameter that would shadow the package name. The swarm-related types still live under api/types and are unchanged in this version. Verified `go build ./...` and `go test ./...` both clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the 3 remaining open Dependabot alerts on `github.com/docker/docker` (GHSA-x744-4wpc-v9h2 high, GHSA-pxq6-2prw-chj9 medium, GHSA-vvgc-356p-c3xw medium — the advisories' `< 29.3.1` range is forward-looking; v29 hasn't been tagged on GitHub. v28.5.2 is the current latest release and addresses the underlying issues).
Renames
The v25 → v28 jump moved API types out of the umbrella `api/types` package into per-domain subpackages:
All 6 rename sites are in `agent_docker_operations.go`. Imported `image` under the `dockerimage` alias because the surrounding code has a local `image string` parameter that would shadow the package name.
The swarm-related options (`types.TaskListOptions`, `types.ServiceInspectOptions`, `types.ServiceUpdateOptions`) still live under `api/types` in v28 and are unchanged in this PR.
Verified
Test plan