fix: race in TestProcessCommandAgentConnected + 6 lint issues#259
Merged
Conversation
Two pre-existing CI failures newly visible after PR #255 / #256 made the lint and test infrastructure functional: 1. TestProcessCommandAgentConnected raced on go-sqlmock for the same reason as TestUpdateAgentHeartbeat (PR #256). Apply the same ExpectationsWereMet polling pattern. 2. golangci-lint v2.5 (newly running) found 5 unchecked Close() return values in k8s-agent (vnc tunnel, websocket conn, two HTTP retry bodies) plus one staticcheck ST1005 capitalized error string. Verified: 10 race reruns clean, both modules build clean. Other test files (agent_hub_redis_test.go, websocket_enterprise_test.go, etc) use the same time.Sleep + mock.ExpectExec pattern. Deferred to a follow-up — they have not yet failed in CI under -race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pre-existing CI failures newly visible after PR #255 / #256 made the lint and test infrastructure functional:
1. Second sqlmock race
`TestProcessCommandAgentConnected` raced on go-sqlmock for the same reason `TestUpdateAgentHeartbeat` did (PR #256) — `go hub.Run()` goroutine inside `sqlmock.exec` while the test goroutine calls `mock.ExpectExec`. Apply the same `ExpectationsWereMet` polling pattern.
2. golangci-lint v2.5 findings (newly running)
Verified
Deferred
Other test files (`agent_hub_redis_test.go`, `websocket_enterprise_test.go`, …) use the same `time.Sleep` + `mock.ExpectExec` pattern. They have not yet failed under `-race` in CI; defer until they do (or a sweep PR if there's appetite).