docs(historical): moby/client SDK migration notes#264
Merged
Conversation
Capture the scope of the deferred github.com/docker/docker -> github.com/moby/moby/client migration so the next person picking it up has a starting point. Covers: - Why the upstream module path moved (moby reorganization, docker-vX tag prefix vs semver, why naive go get fails on v29) - Current pin (docker v28.5.2 still works; this is scope, not bug) - Module import mapping table - Call-signature changes by API method (ContainerCreate, Inspect, ServiceInspect, ServiceUpdate, TaskList, filters) - Call-site inventory with file paths - Suggested approach No code changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Captures the scope of the deferred
github.com/docker/docker→github.com/moby/moby/clientmigration so the next person picking it up has a starting point. No code changes — this is a notes-only PR.Context
We pin
github.com/docker/docker v28.5.2+incompatibletoday (PR #257). The upstream Go module path was deprecated and reorganized:github.com/moby/moby/v2— root module (currentlyv2.0.0-betaN)github.com/moby/moby/api— split-out API types (v1.54.x)github.com/moby/moby/client— standalone client SDK (v0.4.x)I attempted the migration in this session, scoped it carefully, and pulled back rather than ship a half-done refactor. The notes capture what I learned.
What's covered
docker-vXtag prefix vs semver, why a naivego getfor v29 fails)ContainerCreate,ContainerInspect,ServiceInspectWithRaw→ServiceInspect,ServiceUpdate,TaskList, filtersagents/docker-agent/)Allow ~1.5–3 h of careful work for the migration itself.