Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry support #113

Open
Stratus3D opened this issue Apr 3, 2024 · 4 comments
Open

Telemetry support #113

Stratus3D opened this issue Apr 3, 2024 · 4 comments
Labels
client API Anything related to the client API and its quality feature Something new to build

Comments

@Stratus3D
Copy link

Would you be open to a contribution adding telemetry (https://github.com/beam-telemetry/telemetry) support to this library? It'd be nice to have telemetry data for the following events:

  • HTTP requests to the schema registry server
  • Message encode
  • Message decoding
  • Schema encoding
  • Schema decoding

I should be able to make a contribution if this is desired.

@Stratus3D Stratus3D changed the title Telemetry support? Telemetry support Apr 3, 2024
@Strech
Copy link
Owner

Strech commented Apr 4, 2024

Hi @Stratus3D, it's a cool idea. I would appreciate your help.

Unfortunately, I'm not dog-flooding with this project anymore, I'm very concerned about any performance regressions and unnecessary dependencies.

So it would be cool if telemetry would be an optional dependency we could plug in instead of adding it as a base dependency to the project. I'm very open to discussing and collaborating on how we would do it the easiest way.

As a starting point, we can discuss the draft.

@Strech Strech added feature Something new to build client API Anything related to the client API and its quality labels Apr 4, 2024
@Strech
Copy link
Owner

Strech commented Apr 4, 2024

@Stratus3D I've read one more time what this lib provides and I think we can add it to the main dependencies to produce events 👍🏼

@Strech Strech added this to the Pre-major release 0.99 milestone Apr 9, 2024
@Stratus3D
Copy link
Author

Hi @Strech , sorry for the late reply here. I was intending to use this as a dependency in a project I was working on but have since decided to stick with an existing avro library I've built on top of a few other packages. Since I'm not using avrora anymore adding telemetry support here is no longer a priority of mine. Do you want me to close this issue or leave it open for other contributors?

@Strech
Copy link
Owner

Strech commented Apr 16, 2024

Thanks for the reply @Stratus3D, let's keep it, I will look into it and maybe add it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client API Anything related to the client API and its quality feature Something new to build
Projects
None yet
Development

No branches or pull requests

2 participants