Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC Creates wrong notes (photos are not available in note) #2808

Closed
pawlosck opened this issue Apr 26, 2021 · 18 comments
Closed

SC Creates wrong notes (photos are not available in note) #2808

pawlosck opened this issue Apr 26, 2021 · 18 comments
Labels
blocked blocked by another issue bug

Comments

@pawlosck
Copy link

Create any note with photo.

  • Notes are created as anonymous user.
  • photos are not available in note. Server return error 404

For example: https://westnordost.de/p/38938.jpg

SC 31.3
Android: 9.0

Similar issue from 2019

@pawlosck pawlosck added the bug label Apr 26, 2021
@westnordost
Copy link
Member

Always reproducible?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Apr 26, 2021
@pawlosck
Copy link
Author

Yes. I created today a lot of notes and all were created as anonymous user and all photos are not available. Link is available in note, but server return 404.

@westnordost
Copy link
Member

How did you upload the note creations as an anonymous user?

@pawlosck
Copy link
Author

Note was created as anonymous user, but I created using SC.

@westnordost
Copy link
Member

You mean, you created the note, then you logged in and then you uploaded it?

@pawlosck
Copy link
Author

No. I am all time logged in SC. The same time, I tried to answer for normal questions an it looks correctly.

@westnordost
Copy link
Member

Ah okay, so you didn't create the note as an anonymous user, but logged in into your OSM account.

@pawlosck
Copy link
Author

Yes. I tried to use SC as always, but creating notes is broken.

@westnordost
Copy link
Member

@westnordost
Copy link
Member

...which means that this is likely the same issue as #2102 which will be fixed/mitigated in the next major version.

@pawlosck
Copy link
Author

So, could you tell me, why notes were created as anonymous user?

@westnordost
Copy link
Member

They were? I didn't notice that. What is the link again?

@pawlosck
Copy link
Author

This note and other next to Dolnobrzeska street.
https://www.openstreetmap.org/note/2639496#map=18/51.15267/16.86645&layers=N

@westnordost
Copy link
Member

Hm TBH I have no idea. The notes are from you?

The code is like this:

            // let's fail early in case of no authorization
            if (!userController.isLoggedIn) {
                throw OsmAuthorizationException(401, "Unauthorized", "User is not authorized")
            }

            Log.i(TAG, "Starting upload")

            ...

Whatever wrong happened there, I think you are the first to encounter this and likely the easiest solution would be to log out and then log in again.

@pawlosck
Copy link
Author

Yes, these notes are mine. I will try to log out and maybe tomorrow or next days I will try it again.

@matkoniecz
Copy link
Member

Something freaky seems to be going on with notes in general. While logged in on main OSM website:

I am unable to leave comment on existing note

One of notes that I created was created by anonymous user

Another created normally

@matkoniecz
Copy link
Member

matkoniecz commented Apr 26, 2021

Caused by openstreetmap/openstreetmap-website#3184 which will also break commenting in some cases, all methods of interacting with notes are affected

@matkoniecz matkoniecz added blocked blocked by another issue and removed feedback required more info is needed, issue will be likely closed if it is not provided labels Apr 26, 2021
@mnalis
Copy link
Member

mnalis commented Apr 26, 2021

Seems to be solved now in openstreetmap/openstreetmap-website#3185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked blocked by another issue bug
Projects
None yet
Development

No branches or pull requests

4 participants