New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quest suggestion: Is this street lit? #84
Comments
|
Automatic and 24/7 might also apply to non-tunnel situations. So lit results in a 1-out-of-4 selection (no default):
If lit is not
|
|
I'd stuff everything except yes and no into "Other answers...", don't want to clutter up the interface for the standard case. |
|
Visualisation of it: http://product.itoworld.com/map/69 (I'm not sure, but this might be the only consumer of that data) |
Osmand can display it if you enable it in "details". |
|
This is nice, but please also for footways. At least if they are longer than a few meters (which could be connecting footways from a residential to a house). |
|
Also cycleways. |
|
I think that it should be spli into two separate quests (reuse of icon is possible, so difference would not be obvious to user) as asked questions would be different. both quests would ask for objects that fulfill all of following criteria:
general one would skip objects with tunnel key, except tunnel=no tunnel specific would process only objects with tunnel=yes, tunnel=building_passage, tunnel=avalanche_protector Additional idea: maybe show general lit only during night (that is possible to compute from GPS position and time). I am interested in this issue - I am not promising anything but PR is possible. |
|
Not sure if this should be the same quest but a way with |
|
Maybe third group for areas, for user the same as general one
|
I am against this as most of the time you see the street lamps even when it is not dark. You do not know if they are working or operating but still this would reduce impact. |
|
That could be an option for e.g. OsmAnd, not OSM data |
Maybe it is a regional problem but it is quite hard to decide whatever something is lit or not, based solely on presence of streetlamps. For example many footways are not lit despite lamps on the street (only part of road used by cars is lit). |
|
There are places where it is obvious which part is lit. Cycleway on the left is lit, the car road is not. |
|
Yes, but app is unable to guess it. I think that it is better to present questions that almost certainly can be easily answered. |
|
@HolgerJeromin can you check if that example has a separate walk/bicycle way in OSM? If they are two separate ways then it won't be an issue as @matkoniecz said (at least in this configuration). This is more problematic for users, is the sidewalk lit? The road is. Although the situation looks much clearer in OSM data. I say we should start simple and then review the OSM data after a month or two. We can still add the time feature later. Or the layout of the answer could be imporved. |
|
Maybe such a quest could get higher priority at night (real hour for the user, time of the phone) and lower priority at day. edit: Sorry @matkoniecz I missed the comments already made #84 (comment) #84 (comment) with generally the same idea |
|
Though the quest priorities are designed to denote both the order of downloading them and the order in which they are displayed on the map (which one is in front), currently it only applies to download. |
|
@lightonflux my cycleway example are two separate ways in OSM (and already tagged lit+unlit). |
|
It is an expanded spec, now I added also schema of questions that user would answer (and question at the end, feedback would be welcomed). I think that it should be split into separate quests (reuse of icon is possible, so difference would not be obvious to user) as asked questions would be different. both quests would ask for objects that fulfil all of following criteria:
general oneit would skip objects with tunnel key, except tunnel=no asked question: "Is this street lit?"
'Other' would bring subquestion
tunnelstunnel specific would process only objects with tunnel=yes, tunnel=building_passage, tunnel=avalanche_protector asked question: "Is this tunnel lit?" (ask 'Is this passage lit?' for tunnel=building_passage
'Other' would bring subquestion
Additional idea: maybe differ priority of lit quest and increase it during night (that is possible to compute from GPS position and time). Lit may be asked about other objects like pitches, parkings, pedestrian areas, statues, historic buildings etc - but it is probably better to start from less specialized version. At this point I am unsure whatever special version of questions for tunnels is worth it - maybe always include "during night", "never", "always" and leave other options for full scale editors? |
I'd leave this out. If the user is not able to get there, then he can't answer the quest, big deal. There can be many other reasons why a user cannot access a location. But +shrug+ The priority for the user interface design is to make the most usual cases easy to access while not making all the edge cases impossible. Look at taginfo: 99% is yes/no. So, the UI should just be a simple Yes/No answer. Regarding all the other cases, remember, for every quest, there is the "Other answers..." menu available. In this menu, I'd only include "motion detection" and "can't answer" to cover everything else.
I'd say, leave this out first. It can be added later. |
|
I see that there is already quest icon prepared (40c9ee5), I wonder whatever there is need to find suitable images for answers (but I think that this quest would work well also without images).
It will result in some places that should be tagged as |
|
Sounds good, I'd name the item "It's lit night and day" or similar.
…On 27 April 2017 08:58:05 CEST, Mateusz Konieczny ***@***.***> wrote:
I see that there is already quest icon prepared
(40c9ee5),
I wonder whatever there is need to find suitable images for answers
(but I think that this quest would work well also without images).
> Leaving to the user whether he answers "during night" or "always"
will only create confusion. Please leave that out.
It will result in some places that should be tagged as `lit=24/7`
ending as `lit=yes` - but that is result of poorly handled tag system
that for some result decided to put values that should be handled by
multiple tags into one. I am tempted to put 24/7 into 'other' to make
possible to add this data - but yes, that would be at least a bit
confusing...
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#84 (comment)
--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.
|
|
So, are you up for implementing it? If yes, you can create a branch in a fork right away in case you find it helpful if I give you feedback early. |
|
I really want to work on it, but at this moment I make no promises. |
|
@lightonflux: Yes, they're mapped separately (and tagged lit=yes/no) : https://www.openstreetmap.org/way/57372604#map=17/51.86990/8.54413 |
|
In my experience with mapping street lights, a simple "yes/no" only works in the built-up portions of a city (almost always "yes"), or in rural areas (almost always "no"). For everything in between, you frequently need to split a way because the lights end with a change of jurisdiction, or a residential area opted out of street lights while the nearby commercial district didn't, or the lighting status changes for other reasons. |
|
In germany and austria streetlights can be |
|
@lightonflux I think this can be closed, added it in #424 |
|
what about |
|
@ninjamask |
|
@krzyk that commit looks great. We can close this. Do we know when the quest is publicly available? |
|
With v1.1. |

key:lit is a mostly used with
highway. There are different tags for it but these three are best for a quest:It is probably best to narrow this quest down to paved roads and bigger streets. So users don't get bored by hundreds of pathways without lighting.
Answers
The question is strait forward and the options can be easily interpreted in a friendly UI.
UI Mockup
(excuse the particles in my scanner)
Extras questions for tunnels
And maybe these in context of tunnels:
The text was updated successfully, but these errors were encountered: