Skip to content

web: fix tags not adding/removing in note header bar#7623

Merged
thecodrr merged 6 commits into
streetwriters:masterfrom
01zulfi:web/fix-tags
Feb 20, 2025
Merged

web: fix tags not adding/removing in note header bar#7623
thecodrr merged 6 commits into
streetwriters:masterfrom
01zulfi:web/fix-tags

Conversation

@01zulfi
Copy link
Copy Markdown
Member

@01zulfi 01zulfi commented Feb 19, 2025

Signed-off-by: 01zulfi 85733202+01zulfi@users.noreply.github.com

Closes #7621
Closes #7485

@thecodrr
Copy link
Copy Markdown
Contributor

Thanks!

Comment thread apps/web/src/components/editor/header.tsx Outdated
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Comment thread apps/web/src/components/editor/header.tsx Outdated
Signed-off-by: Abdullah Atta <thecodrr@protonmail.com>
Comment thread apps/web/src/stores/editor-store.ts
Signed-off-by: Abdullah Atta <thecodrr@protonmail.com>
@thecodrr
Copy link
Copy Markdown
Contributor

@01zulfi can you add tests for these? I think it's a basic enough functionality that should be tested.

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
@01zulfi 01zulfi requested a review from thecodrr February 20, 2025 05:57
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
@thecodrr thecodrr merged commit 0f2b1d3 into streetwriters:master Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop: Errors removing/updating tags on notes Cannot add/delete Tags anymore (web / macos version)

2 participants