web: fix tags not adding/removing in note header bar#7623
Merged
Conversation
Contributor
|
Thanks! |
thecodrr
requested changes
Feb 19, 2025
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
bea91c2 to
1e5e732
Compare
thecodrr
reviewed
Feb 19, 2025
Signed-off-by: Abdullah Atta <thecodrr@protonmail.com>
thecodrr
reviewed
Feb 19, 2025
Signed-off-by: Abdullah Atta <thecodrr@protonmail.com>
Contributor
|
@01zulfi can you add tests for these? I think it's a basic enough functionality that should be tested. |
This reverts commit 6296c5d.
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
thecodrr
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 01zulfi 85733202+01zulfi@users.noreply.github.com
Closes #7621
Closes #7485