From ee9d0d107996f1d9ddd6cc6c8ee0fd0971bd63cf Mon Sep 17 00:00:00 2001 From: Ben Schumacher Date: Sun, 28 Jan 2018 19:21:31 +0100 Subject: [PATCH 1/3] Remove untested check --- conversions.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/conversions.go b/conversions.go index 5e020f3..2bf37a7 100644 --- a/conversions.go +++ b/conversions.go @@ -40,10 +40,7 @@ func (m Map) Base64() (string, error) { } encoder := base64.NewEncoder(base64.StdEncoding, &buf) - _, err = encoder.Write([]byte(jsonData)) - if err != nil { - return "", err - } + _, _ = encoder.Write([]byte(jsonData)) _ = encoder.Close() return buf.String(), nil From ed60a96a9a27d3e1be23b555c29d625641f9f164 Mon Sep 17 00:00:00 2001 From: Ben Schumacher Date: Sun, 28 Jan 2018 19:22:10 +0100 Subject: [PATCH 2/3] Remove New() call --- map.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/map.go b/map.go index 406bc89..992c4b8 100644 --- a/map.go +++ b/map.go @@ -97,12 +97,12 @@ func MustFromJSON(jsonString string) Map { // // Returns an error if the JSON is invalid. func FromJSON(jsonString string) (Map, error) { - var data interface{} + var data Map err := json.Unmarshal([]byte(jsonString), &data) if err != nil { return Nil, err } - return New(data), nil + return data, nil } // FromBase64 creates a new Obj containing the data specified From fbac91831f02b13c8b3cd3eaf0d2ec0ef741b949 Mon Sep 17 00:00:00 2001 From: Ben Schumacher Date: Sun, 28 Jan 2018 19:22:21 +0100 Subject: [PATCH 3/3] Ingore more files for codeclimate --- .codeclimate.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.codeclimate.yml b/.codeclimate.yml index 010d4cc..f5e9f6f 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -10,4 +10,9 @@ exclude_patterns: - ".github/" - "vendor/" - "codegen/" +- "*.yml" +- "*.md" +- "Gopkg.*" - "doc.go" +- ".gitignore" +- "LICENSE"