fix(html2pdf): Update narrative rules #2466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ak node when no multiline fields
stanislaw
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added narrative rules:
The 2nd is potentially dangerous if the structure consists only of single-column fields and there are a lot of them (more than 20).
This is a temporary fix and may still fail in edge cases. A full solution requires upgrading html2pdf to the 0.2.4+ version (currently in development and not yet released), which resolves conflicts between multiple page-break rules. In complex documents with deep nesting or long nodes, multiple active rules can overload the algorithm, resulting in empty pages or page breaks in undesirable places.
Attached is the most layout-intensive document we have so far — its rendering now looks acceptable.
User Guide - PDF.pdf