fix(export/html): Consider MARKUP = Text option in source file view #2545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haxtibal
force-pushed
the
tdmg/fix_text_nodes_in_source_view
branch
from
b16767b to
9c651e9
Compare
Previously, RST was hard-coded. Fix it by checking on a per-node basis if RST or Text rendering shall be used. It's not possible to do this on a per-source-file basis, since requirements for one source file may come from multiple documents and the MARKUP option is attached to that documents, not to the source file. Fixes strictdoc-project#2544.
haxtibal
force-pushed
the
tdmg/fix_text_nodes_in_source_view
branch
from
9c651e9 to
c9559fb
Compare
haxtibal
changed the title
stanislaw
approved these changes
Nov 4, 2025
Collaborator
stanislaw
left a comment
stanislaw
left a comment
There was a problem hiding this comment.
I think the 'get markup' part could go to the SDocNode class eventually but it is not important to do it right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
RSTwas hard-coded.Fix it by checking on a per-node basis if
RSTorTextrendering shall be used. It's not possible to do this on a per-source-file basis, since requirements for one source file may come from multiple documents and the MARKUP option is attached to that documents, not to the source file.Fixes #2544.