feat(backend/sdoc_source_code): Linux Kernel Template proposal: auto-generate SPDX-Req-ID and SPDX-Req-HKey #2555

stanislaw · 2025-11-13T22:06:37Z

No description provided.

…uments for better readability The upcoming PR #2555 adds some more variables to this class, and it feels like it is time to enforce the explicit argument names every time this class's constructor is called.

…uments for better readability The upcoming PR #2555 adds some more variables to this class, and it feels like it is time to enforce the explicit argument names every time this class's constructor is called. This should help with avoiding the issues when a wrong position argument can be set in place of the right one.

… arguments for better readability The upcoming PR #2555 adds some more variables to this class, and it feels like it is time to enforce the explicit argument names every time this class's constructor is called. This should help with avoiding the issues when a wrong position argument can be set in place of the right one.

…eprocessing code comments In the upcoming #2555, it is important that all whitespace is preserved because the exact byte locations are used for writing modified source code comments back to the source files.

… tests, add a MarkerParser-level Linux/SPDX test This change is one more fragment from a larger #2555 extracted for an easier review. The custom assertion helpers are introduced to the test_marker_lexer which reduces the test boilerplate. The marker parser-level test_80_linux_spdx_example is introduced to verify that the comments are parsed correctly. Previously this test only existed at the marker lexer level.

strictdoc/backend/sdoc_source_code/models/source_file_info.py

strictdoc/backend/sdoc_source_code/models/source_node.py

strictdoc/commands/manage_autouid_command.py

haxtibal · 2025-11-15T08:38:11Z

Everything I've commented here can also be addressed in upcoming PRs. Approving right now, please decide on your own what to address now or later.

strictdoc/backend/sdoc_source_code/models/source_node.py

strictdoc/cli/main.py

strictdoc/commands/manage_autouid_command.py

strictdoc/core/project_config.py

tests/unit/strictdoc/backend/sdoc_source_code/test_marker_parser.py

…generate SPDX-Req-ID and SPDX-Req-HKey

…generate SPDX-Req-ID and SPDX-Req-HKey (code review)

…DE_STRING_VALUE strictdoc#2554 added dedent logic, strictdoc-project#2555 added hash generation. that hash results for same input were different on Windows and Linux even if CR LF was normalized to LF. Further investigation revealed that dedent logic didn't work as expected on Windows, because CR LF got split half into the string token, and half into the newline token, which in turn confused the dedent logic. By trial it turned out that "/[^\n\r]+/x" (verbose regex mode, real newlines) is not the same as "/[^\\n\\r]+/" (normal regex mode, symbolized newlines). The former wrongly lets lark scan a \r into NODE_STRING_VALUE. Thus change to the latter pattern.

stanislaw added this to the 2025-Q4 milestone Nov 13, 2025

stanislaw force-pushed the stanislaw/write_back_ast branch 4 times, most recently from d900fed to 674a7c5 Compare November 13, 2025 23:39

stanislaw mentioned this pull request Nov 14, 2025

chore(backend/sdoc_source_code): Function class: require explicit arguments for better readability #2556

Merged

stanislaw mentioned this pull request Nov 14, 2025

chore(backend/sdoc_source_code): MarkerParser class: require explicit arguments for better readability #2557

Merged

stanislaw mentioned this pull request Nov 14, 2025

feat(backend/sdoc_source_code): MarkerParser: preserve spaces when preprocessing code comments #2558

Merged

stanislaw mentioned this pull request Nov 14, 2025

refactor(backend/sdoc_source_code): add test helpers for marker_lexer tests, add a MarkerParser-level Linux/SPDX test #2559

Merged

stanislaw force-pushed the stanislaw/write_back_ast branch 2 times, most recently from 5643e7f to 0e25f07 Compare November 14, 2025 15:09

stanislaw changed the title ~~feat(backend/sdoc_source_code): Linux Kernel Template proposal: automatic generation of SPDX-Req-ID and SPDX-Req-HKey~~ feat(backend/sdoc_source_code): Linux Kernel Template proposal: auto-generate SPDX-Req-ID and SPDX-Req-HKey Nov 14, 2025

stanislaw force-pushed the stanislaw/write_back_ast branch from 0e25f07 to af9f595 Compare November 14, 2025 17:09

stanislaw requested a review from haxtibal November 14, 2025 17:22

stanislaw force-pushed the stanislaw/write_back_ast branch 4 times, most recently from 6360bbb to 7be34cf Compare November 14, 2025 23:09