Clean up and rename initial test

edgenard · edgenard · commit 72de92f8adfc · 2018-05-13T13:07:35.000-04:00
diff --git a/refactoring_external_service/youtube_video_list_spec.rb b/refactoring_external_service/youtube_video_list_spec.rb
@@ -26,7 +26,7 @@ def video_stats(ids=:NotGivenToStub)
         end
     end
     
-    def test_video_list_returns_video_list
+    def test_when_views_unchanged_for_one_month
         video_repo_response = [{'youtubeID' => 'blahblahblah', 'views' => 3, 'monthlyViews' => 3}]
         youtube_client_response =  {'items' => 
             [
@@ -41,7 +41,6 @@ def test_video_list_returns_video_list
             video_repo: VideoRepoStub.new(video_repo_response), 
             video_client: YoutubeVideoClientStub.new(youtube_client_response)
         )
-        video_json = JSON.generate(video_repo_response)
 
         actual = JSON.parse(video_service.video_list)
         expected = video_repo_response

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ def video_stats(ids=:NotGivenToStub)`
`26`	`26`	`end`
`27`	`27`	`end`
`28`	`28`
`29`		`- def test_video_list_returns_video_list`
	`29`	`+ def test_when_views_unchanged_for_one_month`
`30`	`30`	`video_repo_response = [{'youtubeID' => 'blahblahblah', 'views' => 3, 'monthlyViews' => 3}]`
`31`	`31`	`youtube_client_response = {'items' =>`
`32`	`32`	`[`
`@@ -41,7 +41,6 @@ def test_video_list_returns_video_list`
`41`	`41`	`video_repo: VideoRepoStub.new(video_repo_response),`
`42`	`42`	`video_client: YoutubeVideoClientStub.new(youtube_client_response)`
`43`	`43`	`)`
`44`		`- video_json = JSON.generate(video_repo_response)`
`45`	`44`
`46`	`45`	`actual = JSON.parse(video_service.video_list)`
`47`	`46`	`expected = video_repo_response`