[Editor] Allow drag and drop of EntityComponent #1921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manio143
approved these changes
Oct 11, 2023
| @@ -72,35 +72,40 @@ public async Task AnalyzeProject(SessionViewModel session, Project project, Canc | |||
|
|
|||
| var assemblyFullName = gameProjectCompilation.Assembly.Name; | |||
|
|
|||
| var strideScriptType = typeof(ScriptComponent); | |||
| var strideScriptType = typeof(EntityComponent); | |||
There was a problem hiding this comment.
nit: maybe rename variable to strideComponentType?
| { | ||
| /// <inheritdoc /> | ||
| protected override bool CanAddOrInsert(EntityHierarchyItemViewModel parent, ScriptSourceFileAssetViewModel asset, AddChildModifiers modifiers, int index, out string message, params object[] messageArgs) | ||
| { | ||
| var scriptType = FindScriptType(asset.ServiceProvider, asset.AssetItem)?.FirstOrDefault(); | ||
| if (scriptType == null) | ||
| { | ||
| message = $"No scripts inheriting from {nameof(ScriptComponent)} found in asset {asset.Url}"; | ||
| message = $"No scripts inheriting from {nameof(EntityComponent)} found in asset {asset.Url}"; |
There was a problem hiding this comment.
nit: "No components inheriting..."
Eideren
force-pushed
the
entitycomponent_fix
branch
from
3d0b5bb to
643c987
Compare
|
Rebased to fix merge issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Also includes a fix to avoid crashing the editor when a file which previously had a script now doesn't anymore but is still drag and dropped onto an entity.
Related Issue
None
Types of changes
Checklist