Fixes OpenGL

[MaximilianEmel]

PR Details

Updates Stride.Graphics' OpenGL to match the new version of the API that's used in Silk.NET-2.17.1

Description

• SearchPathContainer is now an array
• Replaced specific enums with the generic GLEnum

Related Issue

#1911

Motivation and Context

When updating OpenXR to the latest version, Silk's OpenGL bindings also got updated, which updated the version of OpenGL, which had breaking changes.

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My change requires a change to the documentation.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have built and run the editor to try this change out.

[MaximilianEmel]

The editor and a project also built with OpenGLES, but the game didn't launch. It is likely Stride is generally not setup to work with OpenGLES on Windows/Desktop, or my graphics driver doesn't support OpenGLES.

[MaximilianEmel]

I believe there's still work to be done (some visible differences in the rendering between D3D11 and OpenGL), but I haven't checked if that's been introduced from the Silk upgrade, or was always like that. There's also quite a lot of Deprecated things, that while still continue to function, ideally should be updated at some point.

[MaximilianEmel]

Results from testing against 83fdc04 (last working version of OpenGL on Windows):

• The rendering differences are the same.
• The same error still occurs apon launching the game with OpenGLES on Windows.

Conclusions:

• No rendering issues are originating as a result of the Silk.NET upgrade.
• OpenGLES still needs to be tested for its target platforms, though I believe it should work.

[manio143]

Can you make those properties { get; } = instead of => to avoid per call allocations of the array?

[MaximilianEmel]

I'll look into this as soon as I can.

[MaximilianEmel]

I modeled how I did it based on how Silk.NET internally does the same thing (should we do a pull to Silk to change this?): e.g. https://github.com/dotnet/Silk.NET/blob/da7cae57614f91d0387fa51af8a52c99b7c43d98/src/Windowing/Silk.NET.SDL/SDLLibraryNameContainer.cs

[MaximilianEmel]

In fact, does it even make sense in the first place to have this file here, instead of just the one already in Silk.NET? See: https://github.com/dotnet/Silk.NET/blob/da7cae57614f91d0387fa51af8a52c99b7c43d98/src/OpenGL/Silk.NET.OpenGL/GLCoreLibraryNameContainer.cs

[MaximilianEmel]

After I do an Android (OpenGLES) build test, it should be ready to merge.

[manio143]

I see that just as there was GLCoreLibraryNameContainer there's also OpenGLESLibraryNameContainer in Stride code base. Those were introduced by @xen2 in f982b42

[MaximilianEmel]

I have been modifying both.

[tebjan]

Great, thanks a lot!