-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Use central package management #2045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use central package management #2045
Conversation
@@ -223,7 +223,7 @@ | |||
|
|||
<!-- SourceLink --> | |||
<ItemGroup> | |||
<PackageReference Include="Microsoft.SourceLink.GitHub" Condition="'$(StrideProjectType)' == 'CSharp'" Version="1.0.0" PrivateAssets="All"/> | |||
<PackageReference Include="Microsoft.SourceLink.GitHub" Condition="'$(StrideProjectType)' == 'CSharp'" VersionOverride="1.0.0" PrivateAssets="All"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is a bit hackish but necessary because the Directory.Packages.props
gets imported later, and the build complains if we try to use Version
nonetheless.
2b99765
to
6e0ceec
Compare
6e0ceec
to
42a23cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I ran it and double-check the nuget resolver result (on GameStudio only) to check if no package unintentionally changed/added/removed: it was all good.
Great change, thanks again.
# Conflicts: # sources/engine/Stride.Input/Stride.Input.csproj
Thanks for the review @xen2. I have resolved the conflict from latest |
Note: some versions used here are more recent than in other projects, so an override was set.
Noticed a small issue when building package:
|
Should be fixed by the other PR that moved the props file #2055 to avoid conflicts with deps. |
PR Details
https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management
Description
Adds
Directory.Packages.props
and references all package versions there.Related Issue
Discussed on Discord.
Motivation and Context
Prevent out-of-sync dependencies between projects.
Types of changes
Checklist