Skip to content

Fix: ChannelMicroThreadAwaiter pooling bug - #2373

Merged
Eideren merged 1 commit into
stride3d:masterfrom
timcassell:fix-microthreadawaiter-pool
Jul 6, 2024
Merged

Eideren merged 1 commit into
stride3d:masterfrom
timcassell:fix-microthreadawaiter-pool

Conversation

@timcassell

Copy link
Copy Markdown
Contributor

PR Details

When >= 4096 awaiters are pooled, more awaiters are also added to the pool without being reset. This has the effect of possibly causing some await Script.NextFrame() points to continue immediately. This PR fixes that issue.

Related Issue

n/a

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren
Eideren merged commit c5bc5a2 into stride3d:master Jul 6, 2024
@Eideren

Eideren commented Jul 6, 2024

Copy link
Copy Markdown
Collaborator

Thanks !

@Eideren Eideren added the area-Core Issue of the engine unrelated to other defined areas label Jul 6, 2024
@timcassell
timcassell deleted the fix-microthreadawaiter-pool branch July 7, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Core Issue of the engine unrelated to other defined areas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants