Skip to content

fix: Regression in mesh bounds calculation introduced through #2858 - #2952

Merged
Eideren merged 2 commits into
stride3d:masterfrom
johang88:modelboundingboxfix
Oct 26, 2025
Merged

Eideren merged 2 commits into
stride3d:masterfrom
johang88:modelboundingboxfix

Conversation

@johang88

Copy link
Copy Markdown
Contributor

Fixes #2948

Changed ComputeBounds helper to be class instead of struct as it contained stateful data that was not retained due to copy by value semantics.

Related Issue

#2948

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@johang88
johang88 force-pushed the modelboundingboxfix branch from c69f299 to f8cfb23 Compare October 26, 2025 12:39
Fixes stride3d#2948

Changed ComputeBounds helper to be class instead of struct as
it contained stateful data that was not retained due to copy by
value semantics.
@johang88
johang88 force-pushed the modelboundingboxfix branch from f8cfb23 to d560517 Compare October 26, 2025 12:43
@Eideren

Eideren commented Oct 26, 2025

Copy link
Copy Markdown
Collaborator

Thanks for that, I meant to swap these to allow ref structs but I got sidetracked and never got back to it it seems.

@Eideren Eideren changed the title Fixed mesh bounding box calculation. fix: Regression in mesh bounds calculation introduced through #2858 Oct 26, 2025
@Eideren
Eideren merged commit 8e791ad into stride3d:master Oct 26, 2025
xen2 pushed a commit that referenced this pull request Dec 2, 2025
xen2 pushed a commit that referenced this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The model thumbnails and asset preview are not working

2 participants