Repository navigation
fix: Regression in mesh bounds calculation introduced through #2858 - #2952
Merged
Merged
Conversation
johang88
force-pushed
the
modelboundingboxfix
branch
from
October 26, 2025 12:39
c69f299 to
f8cfb23
Compare
Fixes stride3d#2948 Changed ComputeBounds helper to be class instead of struct as it contained stateful data that was not retained due to copy by value semantics.
johang88
force-pushed
the
modelboundingboxfix
branch
from
October 26, 2025 12:43
f8cfb23 to
d560517
Compare
Collaborator
|
Thanks for that, I meant to swap these to allow ref structs but I got sidetracked and never got back to it it seems. |
xen2
pushed a commit
that referenced
this pull request
Dec 2, 2025
xen2
pushed a commit
that referenced
this pull request
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2948
Changed ComputeBounds helper to be class instead of struct as it contained stateful data that was not retained due to copy by value semantics.
Related Issue
#2948
Types of changes
Checklist