Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation unknown properties #242

Merged
merged 5 commits into from Jun 11, 2019
Merged

Conversation

@ppatierno
Copy link
Member

ppatierno commented Jun 10, 2019

This PR fixes #240 but also ...

... fixes some tests due to adding the additionalProperties: false which makes the OpenAPI validator doing more work on validation (not done before).
... fix a "bug" in the documentation generation which was blocking Travis to be successful
... defines the partition-id as Integer instead of String in the related endpoint for validating it

Please note that, even if the OpenAPI JSON file seems to be different with huge parts removed, actually there are only a few small changes (it seems that apicurio likes to move things sometimes).

ppatierno added 3 commits Jun 10, 2019
Added tests for unknown properties and topics/topic_pattern usage
Fixed partition-id as Integer on the related endpoint
Fixed test about wrong String partition-id on the related endpoint
Fixed test about specifying partition in the body but on a partition
oriented endpoint
Fixed message to build the right autogenerated doc
@ppatierno ppatierno requested review from tombentley, scholzj and stanlyDoge Jun 10, 2019
.gitignore Outdated
@@ -29,3 +29,6 @@ hs_err_pid*
.vscode/

.DS_Store

# Auto generated doc
**/html*/*

This comment has been minimized.

Copy link
@scholzj

scholzj Jun 10, 2019

Member
Suggested change
**/html*/*
documentation/html/**
documentation/htmlnoheader/**
documentation/book/build/**
Copy link
Member

tombentley left a comment

LGTM

@ppatierno ppatierno merged commit 0e1f3ac into master Jun 11, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ppatierno ppatierno deleted the fix-validation-unknown-properties branch Jun 11, 2019
@ppatierno ppatierno added this to the 0.12.0 milestone Jun 11, 2019
ppatierno added a commit that referenced this pull request Jun 11, 2019
* Added additionalProperties to false in the OpenAPI spec
Added tests for unknown properties and topics/topic_pattern usage
Fixed partition-id as Integer on the related endpoint
Fixed test about wrong String partition-id on the related endpoint
Fixed test about specifying partition in the body but on a partition
oriented endpoint

* Minor fixes

* Delete generated HTML docs
Fixed message to build the right autogenerated doc

* Review comments

* Building a meaningful error message for ValidationException(s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.