Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolling update timeout #127

Closed
scholzj opened this issue Jan 4, 2018 · 1 comment
Closed

Rolling update timeout #127

scholzj opened this issue Jan 4, 2018 · 1 comment
Assignees
@sknot-rh
Labels
cluster operator
Milestone
0.5.0

Comments

@scholzj
Copy link
Member

scholzj commented Jan 4, 2018

The rolling update is currently using a Watch to make sure the pod has been deleted. The watch has no timeout. So if it is for whatever reason started only after the Pod is deleted, it would wait forever. We should probably add some timeout and cancel / restart the rolling update if the Pod is not deleted within the timeout.
@scholzj
Copy link
Member Author

scholzj commented Feb 28, 2018 •
edited by ppatierno

Do not add timeout only:

  • reuse waitUntilReady
  • make it non-blocking
  • add deadline which causes error
  • Make it configurable

@scholzj scholzj mentioned this issue May 14, 2018
Closed
This was referenced May 31, 2018
Closed
Merged
@scholzj scholzj added this to the 0.5.0 milestone Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sknot-rh sknot-rh

Labels
cluster operator
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@scholzj @sknot-rh