Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources configuration should be properly passed from MirrorMaker CR to the Deployment #1494

Merged
merged 3 commits into from Apr 2, 2019

Conversation

Projects
None yet
3 participants
@scholzj
Copy link
Member

commented Apr 2, 2019

Type of change

  • Bugfix

Description

The Resource configuration is never parsed from the MirrorMaker CRD and passed into the deployment. This has been reported in #1493. This PR should fix it.

Checklist

  • Write tests
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging

scholzj added some commits Apr 2, 2019

@scholzj scholzj added this to the 0.12.0 milestone Apr 2, 2019

@scholzj scholzj requested a review from stanlyDoge Apr 2, 2019

@stanlyDoge
Copy link
Member

left a comment

LGTM

@ppatierno
Copy link
Member

left a comment

LGTM

@scholzj scholzj merged commit 8f3019f into master Apr 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@scholzj scholzj deleted the resources-in-mirror-maker branch Apr 2, 2019

scholzj added a commit that referenced this pull request Apr 26, 2019

Resources configuration should be properly passed from MirrorMaker CR…
… to the Deployment (#1494)

* Resources configuration should be properly passed from MirrorMaker CR to the Deployment - Closes #1493

* Fix imports

* Fix spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.