Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init container fields to ignored paths in StatefulSet diff #384

Merged
merged 1 commit into from Apr 17, 2018

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Apr 16, 2018

Type of change

  • Bugfix
  • Enhancement / new feature
  • Refactoring

Description

Persistent Kafka / Zookeeper on Kubernetes use init container to set permissions. Some fields of the init container are changing the triggering permanent rolling update. This PR adds these fields to the ignore list:

/spec/template/spec/initContainers/0/imagePullPolicy
/spec/template/spec/initContainers/0/resources
/spec/template/spec/initContainers/0/terminationMessagePath
/spec/template/spec/initContainers/0/terminationMessagePolicy

@scholzj scholzj requested a review from tombentley April 16, 2018 17:17
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scholzj have you already tried these changes ? I was notified by a 0.3.0-rc2 by GitHub but then the release wasn't there in order to test it.

@tombentley tombentley mentioned this pull request Apr 17, 2018
6 tasks
Copy link
Member

@tombentley tombentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj
Copy link
Member Author

scholzj commented Apr 17, 2018

@ppatierno Yeah, I had the RC2 ready, but then I realized that we have to also handle the init container when the storage type is changed. That will be another PR.

@scholzj scholzj merged commit 3add1b2 into master Apr 17, 2018
@scholzj scholzj deleted the init-container-diff branch April 17, 2018 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants