Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert some more changes when storage type change is attempted #386

Merged
merged 2 commits into from Apr 17, 2018
Merged

Revert some more changes when storage type change is attempted #386

merged 2 commits into from Apr 17, 2018

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Apr 17, 2018

Type of change

  • Bugfix
  • Enhancement / new feature
  • Refactoring

Description

When storage type change is tried for a running cluster, we should revert also the SecurityContext and the Init containers. In the past we reverted only the volumes.

tombentley
tombentley reviewed Apr 17, 2018
View reviewed changes
Copy link
Member

@tombentley tombentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why the security context needs to be reverted?

@scholzj
Copy link
Member Author

scholzj commented Apr 17, 2018

@tombentley We set the PodSecurityContext only for persistent storage (it is not needed for ephemeral). And if don't revert it, it would a) cause a rolling update when the storage type is changes (because it will change in the model) and b) it could cause some issues with accessing the disc (we will run persistent volume without setting the fsGroup).

tombentley
tombentley approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@tombentley tombentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ppatierno
ppatierno approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj scholzj merged commit b4043ea into master Apr 17, 2018
@scholzj scholzj deleted the storage-change-init-container branch April 17, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombentley tombentley tombentley approved these changes

@ppatierno ppatierno ppatierno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scholzj @tombentley @ppatierno