Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct default image for S2I #416

Merged
merged 1 commit into from May 3, 2018
Merged

Use correct default image for S2I #416

merged 1 commit into from May 3, 2018

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented May 2, 2018

Type of change

  • Bugfix
  • Enhancement / new feature
  • Refactoring

Description

There is a nasty bug since at least 0.3.0 - the default image for Kafka Connect S2I is using wrong environment variable and thus incorrect image.

@scholzj scholzj added this to the 0.4.0 milestone May 2, 2018
Copy link
Member

@tombentley tombentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj scholzj merged commit 2868931 into master May 3, 2018
@scholzj scholzj deleted the s2i-default-image branch May 3, 2018 06:58
scholzj added a commit that referenced this pull request May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants