Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid patching ServiceAccounts to avoid continual token creation #641

Merged
merged 1 commit into from Jul 24, 2018
Merged

Avoid patching ServiceAccounts to avoid continual token creation #641

merged 1 commit into from Jul 24, 2018

Conversation

tombentley
Copy link
Member

Type of change

  • Bugfix

Description

Patching ServiceAccounts seems to cause new tokens to be created, even if the patch ought to be a no op. This PR changes the default behaviour for patching service accounts to avoid patching them.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

scholzj
scholzj approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ppatierno
ppatierno approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombentley tombentley merged commit a6f81c2 into master Jul 24, 2018
@tombentley tombentley deleted the sa-patch branch July 24, 2018 09:50
@scholzj scholzj modified the milestones: 0.6.0, 0.5.0 Jul 24, 2018
scholzj pushed a commit that referenced this pull request Jul 24, 2018
@tombentley @scholzj
Avoid patching ServiceAccounts, which causes new secret tokens to be …
5adcfd5 
…created (#641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@ppatierno ppatierno ppatierno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tombentley @scholzj @ppatierno