Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mobile, update zh-CN locales #488

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guyskk
Copy link
Contributor

@guyskk guyskk commented Sep 2, 2018

Before:

stringer-story-old
stringer-feeds-old

After:

stringer-story-new
stringer-feeds-new

@guyskk
Copy link
Contributor Author

@guyskk guyskk commented Sep 2, 2018

I don't have permission to add translation in LocaleApp, how to participate in?

@duenni
Copy link

@duenni duenni commented Sep 2, 2018

Will this close #464?

@guyskk
Copy link
Contributor Author

@guyskk guyskk commented Sep 3, 2018

@duenni No, but I can fix it in next commit.

If you device has very small screen(eg: IPhone 4), the layout may broken.

When screen is 375x667 pixel:
stringer-zero

When screen is 320x480 pixel:
stringer-broker

@guyskk
Copy link
Contributor Author

@guyskk guyskk commented Sep 3, 2018

@duenni I just blamed the stylesheets source code, it shows the font-size not change in the last 5 years.
So it's not caused by stringer updates, did you tried other browers and devices?

@duenni
Copy link

@duenni duenni commented Sep 3, 2018

No, I did not try other devices. It's an iPhone SE, resolution should be 1136 x 640 px.

@mockdeep
Copy link
Collaborator

@mockdeep mockdeep commented Feb 20, 2021

@guyskk I know it's been a couple of years, but are you still available to work on this? If so, I think it would be good to break up into separate PRs. One for the translations, one for the layout cleanups, and one for Turbolinks. I'm a little concerned about Turbolinks in particular, as that can cause issues depending on how the JavaScript is set up.

@guyskk
Copy link
Contributor Author

@guyskk guyskk commented Feb 21, 2021

Hi @mockdeep, I didn't use stringer for a long time, and I have build another RSS reader https://github.com/anyant/rssant .

Please feel free to use my code and commits if you need.

@mockdeep
Copy link
Collaborator

@mockdeep mockdeep commented Feb 21, 2021

@guyskk okay, I'll handle it, then. Thanks so much for contributing!

@bitboxer
Copy link
Contributor

@bitboxer bitboxer commented Apr 19, 2022

@mockdeep would love to have those css fixes merged. Should I take over the fixing of this pr?

@mockdeep
Copy link
Collaborator

@mockdeep mockdeep commented Apr 19, 2022

@bitboxer that would be great! If you want to separate out the CSS changes, I'll be happy to review them and get them merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants