Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change on_guild_leave to set a flag #278

Merged
merged 2 commits into from May 11, 2019
Merged

Change on_guild_leave to set a flag #278

merged 2 commits into from May 11, 2019

Conversation

emmiegit
Copy link
Collaborator

In #174, it asks to remove the hook entirely. This PR instead sets a flag on the guild to not break foreign keys, and leaves the existing rows in the tables.

This deletes tasks since those are ephemeral and should be cleaned out.
@emmiegit emmiegit marked this pull request as ready for review May 11, 2019 22:58
@emmiegit emmiegit requested a review from Ma-wa-re May 11, 2019 22:58
@emmiegit
Copy link
Collaborator Author

Thanks @Ma-wa-re

@emmiegit emmiegit merged commit 78752e8 into master May 11, 2019
@emmiegit emmiegit deleted the on-leave branch May 11, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants