Negative excess is not an error.

This can happen when the target number of workers exceeds the number of old / running workers.
contribsys · Apr 8, 2014 · e848a89 · e848a89
1 parent 461b0f0
commit e848a89
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/einhorn/command.rb b/lib/einhorn/command.rb
@@ -438,8 +438,8 @@ def self.cull
         if excess > 0
           Einhorn.log_info("Smooth upgrade: killing off #{excess} old workers.", :upgrade)
           signal_all("USR2", old_workers.take(excess))
-        elsif excess < 0
-          Einhorn.log_error("Smooth upgrade: somehow excess is #{excess}!", :upgrade)
+        else
+          Einhorn.log_debug("Not killing old workers, as excess is #{excess}.")
         end
       end