Skip to content

Suppress terminal hyperlinks in non-interactive output#38

Merged
stevekaliski-stripe merged 1 commit into
stripe:mainfrom
Vercantez:fix/no-terminal-escapes-noninteractive
Mar 11, 2026
Merged

Suppress terminal hyperlinks in non-interactive output#38
stevekaliski-stripe merged 1 commit into
stripe:mainfrom
Vercantez:fix/no-terminal-escapes-noninteractive

Conversation

@Vercantez

Copy link
Copy Markdown
Contributor

Fixes #35

Summary

  • suppress OSC 8 hyperlinks when stdout is not a TTY or terminal decoration has been disabled
  • keep explorer URL generation covered with separate unit tests
  • add integration coverage for wallet output and the no-args status view in non-interactive mode

Testing

  • cargo fmt --all -- --check
  • cargo test -p purl hyperlink
  • cargo test -p purl --test wallet_command_tests
  • cargo test -p purl wallet_display_returns_full_address_when_hyperlinks_are_disabled
  • cargo test -p purl --test cli_tests test_no_args_status_view_omits_osc8_hyperlinks_in_non_tty_output -- --exact

@stevekaliski-stripe

Copy link
Copy Markdown
Contributor

Thanks @Vercantez !

@stevekaliski-stripe stevekaliski-stripe merged commit dd74c41 into stripe:main Mar 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants