diff --git a/payments-ui-core/src/main/java/com/stripe/android/ui/core/StripeCardScanProxy.kt b/payments-ui-core/src/main/java/com/stripe/android/ui/core/StripeCardScanProxy.kt index f570cd46d24..9715e8bb982 100644 --- a/payments-ui-core/src/main/java/com/stripe/android/ui/core/StripeCardScanProxy.kt +++ b/payments-ui-core/src/main/java/com/stripe/android/ui/core/StripeCardScanProxy.kt @@ -91,6 +91,7 @@ internal class UnsupportedStripeCardScanProxy : StripeCardScanProxy { "Missing stripecardscan dependency, please add it to your apps build.gradle" ) } + // TODO: add an error here for if the dependency is missing? } override fun attachCardScanFragment( @@ -104,5 +105,6 @@ internal class UnsupportedStripeCardScanProxy : StripeCardScanProxy { "Missing stripecardscan dependency, please add it to your apps build.gradle" ) } + // TODO: add an error here for if the dependency is missing? } } diff --git a/payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardDetailsSectionElementUI.kt b/payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardDetailsSectionElementUI.kt index 88fb86ff073..72fec4c8b64 100644 --- a/payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardDetailsSectionElementUI.kt +++ b/payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/CardDetailsSectionElementUI.kt @@ -43,6 +43,7 @@ fun CardDetailsSectionElementUI( ) if (controller.isCardScanEnabled && controller.isStripeCardScanAvailable()) { ScanCardButtonUI(enabled = enabled) { + // TODO: handle the data in the result intent being missing? controller.cardDetailsElement.controller.numberElement.controller.onCardScanResult( it.getParcelableExtra(CardScanActivity.CARD_SCAN_PARCELABLE_NAME) ?: CardScanSheetResult.Failed( diff --git a/payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/ScanCardButtonUI.kt b/payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/ScanCardButtonUI.kt index 932ab32b24a..ed1759f885d 100644 --- a/payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/ScanCardButtonUI.kt +++ b/payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/ScanCardButtonUI.kt @@ -34,6 +34,7 @@ internal fun ScanCardButtonUI( val cardScanLauncher = rememberLauncherForActivityResult(ActivityResultContracts.StartActivityForResult()) { it.data?.let { + // TODO: log an error here if the card scanner fails? onResult(it) } } @@ -44,6 +45,7 @@ internal fun ScanCardButtonUI( indication = null, enabled = enabled, onClick = { + // TODO: run catching and log if the activity was missing? cardScanLauncher.launch( Intent( context, diff --git a/paymentsheet/src/main/java/com/stripe/android/paymentsheet/analytics/DefaultEventReporter.kt b/paymentsheet/src/main/java/com/stripe/android/paymentsheet/analytics/DefaultEventReporter.kt index 3c10f78b730..ec966919e6b 100644 --- a/paymentsheet/src/main/java/com/stripe/android/paymentsheet/analytics/DefaultEventReporter.kt +++ b/paymentsheet/src/main/java/com/stripe/android/paymentsheet/analytics/DefaultEventReporter.kt @@ -16,6 +16,7 @@ import javax.inject.Inject import javax.inject.Singleton import kotlin.coroutines.CoroutineContext +// TODO: add extra error analytics to this, as well as alerts for these errors @Singleton internal class DefaultEventReporter @Inject internal constructor( private val mode: EventReporter.Mode, diff --git a/stripecardscan/src/main/java/com/stripe/android/stripecardscan/cardscan/CardScanSheet.kt b/stripecardscan/src/main/java/com/stripe/android/stripecardscan/cardscan/CardScanSheet.kt index 3ad0bb3f68c..a8cb52cb09e 100644 --- a/stripecardscan/src/main/java/com/stripe/android/stripecardscan/cardscan/CardScanSheet.kt +++ b/stripecardscan/src/main/java/com/stripe/android/stripecardscan/cardscan/CardScanSheet.kt @@ -184,6 +184,7 @@ class CardScanSheet private constructor(private val stripePublishableKey: String CARD_SCAN_FRAGMENT_REQUEST_KEY, lifecycleOwner ) { _, bundle -> + // TODO: add an error here for params missing? val result: CardScanSheetResult = bundle.getParcelable( CARD_SCAN_FRAGMENT_BUNDLE_KEY ) ?: CardScanSheetResult.Failed(Throwable("Card scan params not provided"))