Skip to content

Conversation

@jofftiquez
Copy link
Contributor

@jofftiquez jofftiquez commented Jan 4, 2021

  • Add yarn usage
  • Add various code formatting (semi-standard)
  • Add code-block type in code samples

- Add yarn usage
- Add various code formatting (semi-standard)
- Add code-block type in code samples
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@dweedon-stripe dweedon-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We made the deliberate decision not to include yarn. We love yarn, but we decided that most developers using yarn will know that it works and know how translate an npm command. Sticking to just npm keeps the readme cleaner.

That said, thanks for fixing the code samples. If you remove the yarn stuff I will get this merged.

Thanks

@jofftiquez
Copy link
Contributor Author

Hello, @dweedon-stripe I understand, thanks. I updated the PR.

remove yarn-related instructions
@dweedon-stripe dweedon-stripe merged commit 5e0cf37 into stripe:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants