Skip to content

Loading…

Added missing data parameter to the internal `get` function... #16

Merged
merged 1 commit into from

2 participants

@xavi-

...that's called in stripe.token.retrieve. This results in stripe.token.retrieve silently failing and the callback parameter never being executed.

@abh

Whoops. I forget if that one is hard to write a test for. If not, could you add a test too so it doesn't happen again somehow? :-)

@abh abh merged commit c1a56e8 into stripe:master
@abh

I wrote a test for it that I'll commit shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 13, 2011
  1. @xavi-

    Added missing data parameter to the internal `get` function that's ca…

    xavi- committed
    …lled in `stripe.token.retrieve`.
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/main.js
View
2 lib/main.js
@@ -143,7 +143,7 @@ module.exports = function (api_key, options) {
post("/v1/tokens", data, cb)
},
retrieve: function (token_id, cb) {
- get("/v1/tokens/" + token_id, cb)
+ get("/v1/tokens/" + token_id, {}, cb)
}
},
};
Something went wrong with that request. Please try again.