Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move child resource method params next to method declarations #1626


Copy link

@pakrym-stripe pakrym-stripe commented Nov 23, 2022

In node, child service methods are inlined into parent service. Before this change ***Params types for child service params were generated in ChildService.ts after this change they move next to method declaration into ParentService.ts. It's not a breaking change.

Checked that all changes are equivalent by running

git diff master types/ | grep '^[-] ' | cut -c 2- | sort > /tmp/removed
git diff master types/ | grep '^[+] ' | cut -c 2- | sort > /tmp/added
diff /tmp/added /tmp/remove

@pakrym-stripe pakrym-stripe merged commit 219796d into master Nov 23, 2022
7 checks passed
@remi-stripe remi-stripe deleted the pakrym/Move_child_resource_method_params_next_to_method_declarations branch September 28, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants