Add phpcs to travis to check that code matches zend style #47

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@jpiasetz
Contributor

This adds CodeSniff to travis to complain when stuff gets off the style guide. Will need to be changed based on #43. I also updated it to use the git repo instead of downloading from sourceforge. The codesniff only needs to be run on one copy so so I force it on 5.5.

@michelle
Contributor

Hmm, any idea why the first build fails with Fatal error: Class 'Phar' not found in /home/travis/.phpenv/versions/5.2.17/bin/composer.phar on line 13?

@jpiasetz
Contributor

It's existing behaviour (it's happening on other builds as well). The probably changed what they have on php5.2 since the travis config was update. They have this warning http://docs.travis-ci.com/user/languages/php/#PHP-installation I could just not do much on 5.2?

@bkrausz
Contributor
bkrausz commented Jun 22, 2014

Added phpcs to the build (only on 5.6) based off of your diff, as well as fixing some style issues that built up over the last 3 months. Thanks!

@bkrausz bkrausz closed this Jun 22, 2014
@jpiasetz
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment