Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow falsy ID for plans #68

Merged
merged 4 commits into from May 21, 2014

Conversation

Projects
None yet
2 participants
Contributor

KorvinSzanto commented Dec 20, 2013

I encountered this issue, and saw that this was already reported in #55.
The fix I've included will solve the issue, but might impact other things, so this should be tested carefully.

@KorvinSzanto KorvinSzanto Allow falsy ID for plans
I encountered this issue, and saw that this was already reported in #55.
The fix I've included will solve the issue, but might impact other things, so this should be tested carefully.
b41f542
Contributor

michelle commented Jan 22, 2014

Thanks for this! I'll add a test case and merge soon.

@michelle michelle was assigned Jan 22, 2014

Contributor

KorvinSzanto commented Jan 23, 2014

I'll add a commit for a test case.

@michelle michelle and 1 other commented on an outdated diff Mar 7, 2014

test/Stripe.php
@@ -33,24 +33,4 @@ function exception_error_handler($errno, $errstr, $errfile, $errline) {
require_once(dirname(__FILE__) . '/../lib/Stripe.php');
require_once(dirname(__FILE__) . '/Stripe/TestCase.php');
-
-require_once(dirname(__FILE__) . '/Stripe/ApiRequestorTest.php');
@michelle

michelle Mar 7, 2014

Contributor

Hmm, could we put these back in place? :)

@KorvinSzanto

KorvinSzanto Mar 7, 2014

Contributor

How did this happen? haha.

Why add composer.phar?

Contributor

KorvinSzanto commented Mar 11, 2014

I don't remember the reasoning for composer.phar to .gitignore, I've reverted that change.
The other changes were done in testing, I should've caught that.

Contributor

michelle commented Mar 11, 2014

Cool, thanks a lot for this! I'll merge it in sometime this week. In the meantime, could you make sure everything complies with the Zend style guide? (http://framework.zend.com/manual/1.12/en/coding-standard.coding-style.html)

Contributor

KorvinSzanto commented Mar 13, 2014

I'll update the code to follow the zend style guide sans the four space requirement, is there something specific you see that you'd like me to fix?

Contributor

michelle commented Mar 13, 2014

Nope, looks good otherwise.

@michelle michelle merged commit 35dd927 into stripe:master May 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment