Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove Stripe_Util::cloneArray() #7
Summary: PHP has copy-on-write value-semantics for arrays. This method doesn't do anything. It would break references and convert Iterators to raw arrays, but isn't used to do either.
My editor also stripped some trailing whitespace.
I tried to figure out what problem this was solving when it was introduced, but blame goes past the first commit.
Test Plan: Ran unit tests. Many of them fail -- they seem to depend on a specific API key? Is there a way I can get them to work? But, these failures were the same before this change. Added a troll test to demonstrate that PHP has the behavior I claim it does. Grepped for 'arrayClone()'.