to_dict() does not account for lists #17

tghw opened this Issue May 30, 2012 · 2 comments


None yet

2 participants

tghw commented May 30, 2012

The to_dict() function does not properly serialize the whole object, since lists that could potentially contain StripeObjects are passed through as-is. A good example is the Invoice object, invoice['list']['subscriptions'][0] is still a StripeObject.

Since this stuff is all mechanical, it should be pretty easy to write unit tests for, too.

@ebroder ebroder pushed a commit that referenced this issue May 31, 2012
@evan-stripe evan-stripe Add tests for #17 and #18 60d0261
ebroder commented May 31, 2012

Hmm, looks like these didn't get auto-closed. In any case, thanks for the bug reports and the fixes. I've just released v1.7.2 with the fixes.

@ebroder ebroder closed this May 31, 2012
tghw commented May 31, 2012

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment